DEVOPS-1154: address warnings upon publishing Python packages from GitHub - #166
Open
RomFloreani wants to merge 3 commits into
Open
DEVOPS-1154: address warnings upon publishing Python packages from GitHub#166RomFloreani wants to merge 3 commits into
RomFloreani wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflows to address warnings when publishing Python packages from GitHub, shifting PyPI/TestPyPI publishing to OIDC trusted publishing (run in-repo) and aligning workflow calls to updated CI-tools implementations.
Changes:
- Switch PyPI/TestPyPI publishing to an in-workflow job that uses a composite action for OIDC trusted publishing.
- Remove reliance on
PYPI_TOKEN/TEST_PYPI_TOKENsecrets for publishing. - Update multiple reusable workflow
uses:references to CI-toolsDEVOPS-1154.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/security_scan.yml | Updates CI-tools reusable workflow refs for Zizmor scanning jobs. |
| .github/workflows/python_deploy_prod.yml | Adds a dedicated in-repo PyPI publish job (OIDC) and updates CI-tools workflow refs. |
| .github/workflows/python_deploy_dev.yml | Adds a dedicated in-repo TestPyPI publish job (OIDC) and updates CI-tools workflow refs. |
| .github/workflows/pr_jira_actions.yml | Updates CI-tools reusable workflow ref for PR→Jira automation. |
| .github/workflows/issue_to_jira.yml | Updates CI-tools reusable workflow ref for issue→Jira automation. |
Suppressed comments (5)
.github/workflows/security_scan.yml:45
- Using a moving branch ref (
@DEVOPS-1154) for a reusable workflow makes the CI supply chain mutable (the branch can be force-pushed/deleted) and can break reproducibility/auditing. Prefer pinning to an immutable commit SHA (or a released tag once available).
uses: MiraGeoscience/CI-tools/.github/workflows/reusable-zizmor-annotate.yml@DEVOPS-1154
.github/workflows/python_deploy_prod.yml:44
- Using a moving branch ref (
@DEVOPS-1154) for a reusable workflow makes the CI supply chain mutable (the branch can be force-pushed/deleted) and can break reproducibility/auditing. Prefer pinning to an immutable commit SHA (or a released tag once available).
uses: MiraGeoscience/CI-tools/.github/workflows/reusable-python-release_pypi_assets.yml@DEVOPS-1154
.github/workflows/python_deploy_prod.yml:69
- Using a moving branch ref (
@DEVOPS-1154) for the composite action makes the publish step mutable and harder to audit. Prefer pinning to an immutable commit SHA (or a released tag once the CI-tools changes are released).
uses: MiraGeoscience/CI-tools/.github/actions/reusable-python-publish_to_pypi@DEVOPS-1154
.github/workflows/python_deploy_dev.yml:32
- Using a moving branch ref (
@DEVOPS-1154) for a reusable workflow makes the CI supply chain mutable (the branch can be force-pushed/deleted) and can break reproducibility/auditing. Prefer pinning to an immutable commit SHA (or a released tag once available).
uses: MiraGeoscience/CI-tools/.github/workflows/reusable-python-publish_pypi_package.yml@DEVOPS-1154
.github/workflows/python_deploy_dev.yml:59
- Using a moving branch ref (
@DEVOPS-1154) for the composite action makes the publish step mutable and harder to audit. Prefer pinning to an immutable commit SHA (or a released tag once the CI-tools changes are released).
uses: MiraGeoscience/CI-tools/.github/actions/reusable-python-publish_to_pypi@DEVOPS-1154
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| contents: read | ||
| actions: read | ||
| uses: MiraGeoscience/CI-tools/.github/workflows/reusable-zizmor-advanced-security.yml@v3 | ||
| uses: MiraGeoscience/CI-tools/.github/workflows/reusable-zizmor-advanced-security.yml@DEVOPS-1154 |
| name: Publish production Conda package on JFrog Artifactory | ||
| if: ${{ github.event_name == 'release' || github.event.inputs.publish-conda == 'true' }} | ||
| uses: MiraGeoscience/CI-tools/.github/workflows/reusable-python-release_conda_assets.yml@v3 | ||
| uses: MiraGeoscience/CI-tools/.github/workflows/reusable-python-release_conda_assets.yml@DEVOPS-1154 |
| call-workflow-conda-publish: | ||
| name: Publish development conda package on JFrog Artifactory | ||
| uses: MiraGeoscience/CI-tools/.github/workflows/reusable-python-publish_rattler_package.yml@v3 | ||
| uses: MiraGeoscience/CI-tools/.github/workflows/reusable-python-publish_rattler_package.yml@DEVOPS-1154 |
| call-workflow-pr_jira_actions: | ||
| if: github.event.action != 'edited' || github.event.changes.title != null | ||
| uses: MiraGeoscience/CI-tools/.github/workflows/reusable-jira-pr_actions.yml@v3 | ||
| uses: MiraGeoscience/CI-tools/.github/workflows/reusable-jira-pr_actions.yml@DEVOPS-1154 |
| call-workflow-create-jira-issue: | ||
| if: startsWith(github.repository, 'MiraGeoscience/') # run on the Mira repo only | ||
| uses: MiraGeoscience/CI-tools/.github/workflows/reusable-jira-issue_to_jira.yml@v3 | ||
| uses: MiraGeoscience/CI-tools/.github/workflows/reusable-jira-issue_to_jira.yml@DEVOPS-1154 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEVOPS-1154 - address warnings upon publishing Python packages from GitHub
Summary
PR Checklist
expect style.
to a Pull Request
@simpeg/simpeg-developerswhen ready for review.Reference issue
What does this implement/fix?
Additional information