Repository navigation
Start the authentication fallback over once every scheme has failed - #213
Merged
bertysentry merged 1 commit intoOct 26, 2026
Conversation
Fixes #212. With an ordered fallback list, FallbackAuthScheme kept its start index on the last scheme once that one was rejected too, so every later request only retried it: a client that had moved from NTLM to a disabled Basic, or from Kerberos to a blocked NTLM, failed for good until it was recreated. advance() and the all-failed path of authenticate() now rewind to the first scheme. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
bertysentry
deleted the
212-a-client-gets-stuck-forever-on-a-failing-authentication-method
branch
October 26, 2026 15:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #212.
With an ordered fallback list such as
(KERBEROS, NTLM)or(NTLM, BASIC),FallbackAuthSchemekept its start index on the last scheme once that one was rejected too. Every later request then only retried that scheme: a client that had moved from NTLM to a disabled Basic, or from Kerberos to a blocked NTLM, failed for the rest of its life until it was recreated, even after a transient failure of the first scheme (unreachable KDC, host restarting) was over.advance()and the all-failed path ofauthenticate()now rewind to the first scheme, so the next request starts over. Retrying the last successful scheme first on reconnect is unchanged.FallbackAuthSchemeTest, one per rewind path.authentication.mdunder "Ordered fallback".mvn clean verify sitepasses with checkstyle, PMD and SpotBugs clean. Not tried against a real host with Basic disabled.🤖 Generated with Claude Code