Repository navigation
Document that the Windows launcher alters values with cmd.exe metacharacters (#219) - #233
Conversation
…racters (#219) The ipmicli.cmd shim runs through cmd.exe, which expands %NAME%, drops ^ and runs what follows an unquoted &, |, < or > before the CLI sees its arguments, from PowerShell as well. Until the launcher is replaced, the cli.md password section, the installation page and the installer's closing message tell Windows users to give such a password at the prompt or with -pf, and such a path or name through java -jar. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4280e5d6a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Only a %NAME% reference expands everywhere; ^ & | < > are altered outside double quotes, which PowerShell adds only around a value with a space. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae5fdb3988
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…rShell (#219 review) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Documentation stopgap for #219: the
ipmicli.cmdshim runs through cmd.exe, which expands%NAME%, drops^and runs what follows an unquoted&,|,<or>before the CLI sees its arguments, from PowerShell as well. No batch file can avoid that, and the launcher replacement stays with #219.cli.md, Passwords and BMC key: explains what cmd.exe does to such a value and tells Windows users to give the password at the prompt or with-pf, and such a path or name throughjava -jar.installation.md, launcher paragraph: one sentence pointing to that section.get.ps1: two lines in the installer's closing message.Site built locally (
mvn site), both pages render as intended.get.ps1parses (PowerShell parser, 0 errors).🤖 Generated with Claude Code