Proposal: Deprecate this package #369

Activity

1. kumavis commented on Apr 30, 2021

   

   kumavis

   on Apr 30, 2021

   Contributor

   More actions

   https://www.npmjs.com/package/web3-provider-engine check the versions page, downloads really scattered across the version spectrum
2. kumavis commented on Apr 30, 2021

   

   kumavis

   on Apr 30, 2021

   Contributor

   More actions

   its been reduced to mostly just a shell over json-rpc-engine and eth-json-rpc-middleware, so ideally maintenance burden is small.

   is this in use by metamask mobile via @metamask/controllers?

   to clarify, im not strongly advocating for keeping this repo active, just seeking more info

   I think the Node 14 and 16 issue can be resolved by deprecating the vm middleware, its very outdated anyways. the new ethereumjs-vm implementation does not provide the hooks we need
3. kumavis commented on May 3, 2021

   

   kumavis

   on May 3, 2021

   Contributor

   More actions

   eth-faucet also currently uses provider-engine
4. mcmire

   pinned this issue on Apr 27, 2022
5. mcmire commented on Apr 27, 2022

   

   mcmire

   on Apr 27, 2022

   Last edited by mcmire

   Contributor

   More actions

   I agree with this and am pinning this to the top of the issues list so we don't forget.

   As a part of deprecating this and moving our own packages to use json-rpc-engine, we should also try to help our colleagues within ConsenSys move off of this package. Truffle's hdwallet-provider would be one such example: https://github.com/trufflesuite/truffle/tree/develop/packages/hdwallet-provider.

   👍React with 👍1Reacted by Erik Marks

   👀React with 👀1Reacted by legobeat
6. mcmire commented on Oct 5, 2023

   

   mcmire

   on Oct 5, 2023

   Contributor

   More actions

   I think we should start talking about this again. Since I last posted:

   • We've consolidated the implementation of NetworkController (the module in our wallet architecture we use to talk to the network) between both our browser extension and mobile app.
   • The consolidated version of NetworkController no longer uses web3-provider-engine and now uses our json-rpc-engine middleware stack.
   • Truffle is being sunset. This was the last of the libraries that we (Consensys) produced which still used web3-provider-engine.

   As a result, I don't think we should push any new changes to this library. Instead, I think we should deprecate the library on NPM, change the message in the README to indicate as such, and we should archive this repo instead.

   What do we think?

   👍React with 👍1Reacted by Mark Stacey
7. SebastienGllmt commented on Oct 22, 2023

   

   SebastienGllmt

   on Oct 22, 2023

   Last edited by SebastienGllmt

   More actions

   If anybody else also got sent by chatGPT to this library and is trying to figure out how to upgrade, here is most likely what you need

   import Web3 from 'web3';
   import { JsonRpcEngine } from '@metamask/json-rpc-engine';
   import { providerFromEngine } from '@metamask/eth-json-rpc-provider';
   
   const rpcUrl = ...; // fill in your RPC url here
   
   const engine = new JsonRpcEngine();
   
   // custom middleware to log requests as they happen
   engine.push((req, _, next) => {
     console.dir(req, { depth: null });
     next();
   });
   
   engine.push(createFetchMiddleware({ btoa, fetch, rpcUrl }));
   
   const provider = providerFromEngine(engine);
   // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
   const web3 = new Web3(provider as any);

   👍React with 👍1Reacted by Elliot Winkler
8. desi

   added

   team-shared-libraries

   on Oct 31, 2023
9. Gudahtt

   self-assigned this

   on Mar 26, 2024
10. Gudahtt commented on Mar 28, 2024

    

    Gudahtt

    on Mar 28, 2024

    Member

    More actions

    Done in #469
11. Gudahtt

    closed this as completedon Mar 28, 2024