Repository navigation
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8e74755. Configure here.
hanzel98
force-pushed
the
feat/metaswap-order-delegation-manager
branch
from
October 1, 2026 20:21
fa2e317 to
68a79cb
Compare
One manager for gasless swaps and limit orders, with tests, deployment, and verification.
hanzel98
force-pushed
the
feat/metaswap-order-delegation-manager
branch
from
October 1, 2026 20:25
68a79cb to
28c3d2e
Compare
The hash commits the whole batch, including each target and value, so ExactCalldata described only part of it.
Remove the id==0 bitmap skip so every FlexibleSettlement id burns the bitmap and excludes siblings. Keep flexible gas rows on a nonzero id so measurements stay comparable to the comparison harness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
MetaSwapOrderDelegationManagerfor two flows: exact batches and MetaSwap limit orders.A limit order still requires a listed redeemer, checks the approval and swap shape, and requires the signed minimum output.
disabledDelegationsremains the one-shot for both flows. A failed fill rolls back.Gas
Estimated transaction gas: 21,000 plus calldata plus execution. Each row is the same swap.
Exact batches
Today the signed call is a self-call into the 7702 account, and that call runs the batch. The order manager signs the batch hash and runs the batch directly.
Limit orders
Today this is separate root delegations on
DelegationManager: an approval, then a swap. The flexible settlement enforcer collapses that into one delegation. This manager does too, and it is cheaper than both.The separate-roots baseline uses
IdEnforcerfor the one-shot. The approval root uses id 2 and the swap root uses id 1, because both are redeemed in the same call. The flexible settlement enforcer is the current one, which requires a non-zero id.Saved against the separate roots:
The order manager is also cheaper than the enforcer on every shape:
Scope
0, burns the id bitmap for the delegator and blocks sibling orders that share it. The delegation hash is still one-shot as well. Cancelling does not burn the idenableDelegationDelegationManagerTest plan
MetaSwapOrderDelegationManagerTestpasses, including both flows and the redemption guardsscript/DeployMetaSwapOrderDelegationManager.s.solMETA_SWAP_ORDER_DELEGATION_MANAGER_ADDRESS