Skip to content

fix(gamedata): adopt original Career runtime symbol names - #27

Merged
hzqst merged 1 commit into
mainfrom
fix/career-original-symbol-names
Oct 21, 2026
Merged

hzqst merged 1 commit into
mainfrom
fix/career-original-symbol-names

Conversation

@hzqst

@hzqst hzqst commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

GoldSrc_VibeSignatures v20261021b publishes the original Career global, type and member identities restored by HLND2T/GoldSrc_VibeSignatures#394. The previous lookup names no longer match that catalog, preventing Career storage symbol resolution and manifest validation.

Update all three global lookups and five member lookups together with the consumer manifest, validator, test fixtures and bilingual symbol inventory. Preserve vgui2::g_pFileSystemInterface as the runtime key and the complete vgui2::TextEntry.m_TextStream.m_Size member path with its cumulative TextEntry-relative offset. Split fixture member names only at the first dot to support that nested path.

Validated against the published catalog:

  • Online synchronization/pruning, standalone manifest validation and synchronizer validate-only passed across all 22 snapshots.
  • All eight renamed keys survive pruning for hl-10210, hl-8684 and cstrikegameui-8684; nested TextEntry offsets remain 0x88/0x84/0x84.
  • MSVC x86 Release DLL and test targets built successfully; CTest 8/8 and Python tests 7/7 passed.
  • Pinned format-check passed for all 66 files; Git whitespace checks passed.

The DLL must ship with the updated catalog. This migration was not deployed or tested in-game.

Co-Authored-By: Codex <codex@openai.com>
@hzqst
hzqst merged commit aa532b3 into main Oct 21, 2026
3 checks passed
@hzqst
hzqst deleted the fix/career-original-symbol-names branch October 21, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant