Repository navigation
style(career): reformat profile storage sources to match the original code style - #23
Merged
Merged
Conversation
… code style Layout-only cleanup of the Career profile storage code from #22: one statement per line, blank lines between functions and logical blocks, wrapped long conditions/argument lists, one entry per table row, and explicit braces on nested control flow. No identifiers or comments change. Verified with non-LTCG Release builds: the disassembly of CareerProfileStorage.obj, CareerProfileStorageHooks.obj and GameUI.obj is identical before and after; the test object differs only in assert line numbers. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Layout-only cleanup of the Career profile storage code introduced in #22, so it matches the style of the existing sources in
src/:src/CareerProfileStorageHooks.cpp: one statement per line, blank lines between functions and logical blocks, wrapped long conditions and argument lists, one entry per row inEntryNames/patches/replacements, explicit braces on nestedif/else,Boundary<T>(...)lambdas laid out so clang-format keeps them stable, and file-scope state grouped at the top (adds aCopyFnalias of the identical type).src/CareerProfileStorage.cpp: expanded single-lineifs inNativeWriteAudit, braces on loop-nestedifs, blank lines between logical blocks.src/CareerProfileStorage.h: split multi-variable declarations and separated member groups.tests/career_profile_storage_tests.cpp: expanded one single-lineif.No identifiers, comments or behavior change.
Verification
/GLbefore and after the change and compareddumpbin /disasmoutput (repeat builds of the same source were confirmed deterministic first):CareerProfileStorage.obj,CareerProfileStorageHooks.obj,GameUI.obj: identical.career_profile_storage_tests.obj: differs only inassert__LINE__constants.VGUI2Extensionand tests succeeds;ctest -C Release: 8/8 passed.VGUI2Extension-format-check: 66 files, 0 with differences.🤖 Generated with Claude Code