Repository navigation
fix: wait past the deadline before releasing the stale question in its test - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
PluginApi CIrun for the merge of #13 failed inToolingSessionTest > a question the host gave up on is skipped(ToolingSessionTest.kt:189:/stale.jswas run).A question carries the deadline
send time + timeout. The host stops waiting at that same moment, and the test then released the busy tooling at once. The tooling could pick the question up in the same millisecond as its deadline, andWire.expiredonly counts a deadline as passed once the clock is later than it, so the question ran. It needs a slower machine than the one I wrote it on to show.The test now waits 100 ms after the host gives up, so the deadline has certainly passed. Nothing in
contractchanges.Test plan
:contract:test --tests '*ToolingSessionTest*'six times in a row: 11 of 11 each time. The failure was not reproducible locally before the change either, so the evidence is the cause above and the next CI run.