Repository navigation
fix!: agree on a minimum Binder version instead of an exact interface fingerprint - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
String apiFingerprint()(transaction 100) withint binderVersion()(transaction 101). Number 100 stays retired.BinderContract.MIN_VERSION. Adding a method under a new number keeps working with peers that lack it, which is the point of fixing the numbers; an exact fingerprint rejected every such change.binderVersion, including the fingerprint builds, answer 0 and get the same "rebuild" error.VERSION, so changing the AIDL without raising the version fails.Breaking
Apps and plugins built against 574d927 must be rebuilt together once more.