Repository navigation
First deploy, checked: identity wait, service address, usage, checklist (T12, part 1) - #16
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
The first delivery (v0.1.3, merged with #15) went green on its second attempt. The deploy job signed in five seconds after the apply had made its federated binding, and IAM had not put the binding in force yet. This PR records that delivery and makes the pipeline wait for a new identity. Checking the live deployment found two more defects, and both are fixed here.
Merging this PR is the second delivery. Part 2 of the task uses it to check the delivery queue, rollback and return, and comes back as a second PR with the results.
Changes
ci-identity-readyruns in thedeployandhostingjobs right after sign-in:invalid_grant,invalid_target,unauthorized_client, …).service_urlis now the address made of the service name, project number and region, taken fromurls. Before, it was the address with a random part, fromuri. An output precondition stops the apply if Cloud Run does not report it._Defaultsink:unique_writer_identity = true. Provider 8.3.0 reads a sink with no writer identity as a unique one, sofalseshowed a change in every plan. A sink whose bucket is in its own project never has a writer identity.just usage [window]reads Cloud Run's metrics from the Monitoring API and sets them against a month's free tier (180,000 vCPU-s, 360,000 GiB-s, 2M requests). The token is passed in a header, never on the command line.docs/self-hosting.mdgets a first-delivery checklist of eight commands; the billing account is masked even in errors;docs/live/01-first-deploy.mdreports the first delivery in UTC, with costs and findings;How it was verified
tf-checkruns 18 tests.just usageandci-tf-planran against prod, read-only. After the fix the plan changes no resource, only theservice_urloutput.gcloudandcurl.Before merging
TF_VAR_operator_emailis set, so the second delivery creates the load alert.planjob shows only theservice_urloutput change, plus the alert and its channel if the address is set.firebase), and the narrow live-run permission is in place.Open
cdqueue with the Deploy button, the checklist on v0.1.4, rollback and return,just usage, and the report closed.