msys2 package list clean out and brew gcc update to v14. - #359
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up the msys2 package list for Windows CI jobs and upgrades the macOS compiler in both test and binary‐build workflows from GCC 13 to GCC 14.
- Remove many legacy msys2 packages and streamline installed dependencies.
- Update GitHub Actions matrices to use g++-14 on macOS.
- Change Homebrew logic to install and reference gcc@14 instead of gcc@13.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/tests.yml | Reduced msys2 install list; bumped macOS compiler entries to g++-14. |
| .github/workflows/build_binaries.yml | Adjusted msys2 dependencies; updated Homebrew GCC install and build commands to gcc@14. |
Comments suppressed due to low confidence (3)
.github/workflows/tests.yml:55
- By removing packages like lapack, openblas, pthread and Python bindings, the Windows build or tests may now fail if those libraries are actually required. Please confirm which dependencies are still needed and restore any that are missing.
install: mingw-w64-x86_64-gcc make mingw-w64-x86_64-imagemagick mingw-w64-x86_64-ffmpeg unzip zip git mingw-w64-x86_64-ca-certificates mingw-w64-x86_64-diffutils
.github/workflows/build_binaries.yml:85
- Similar to the tests workflow, critical MSYS2 packages (e.g., libwinpthread, lapack, openblas, Python CFFI) were removed and might be required for a successful Windows binary build. Double-check and re-add missing dependencies.
install: mingw-w64-x86_64-gcc make mingw-w64-x86_64-imagemagick mingw-w64-x86_64-ffmpeg unzip zip git mingw-w64-x86_64-python-zstandard mingw-w64-x86_64-ca-certificates
.github/workflows/build_binaries.yml:137
- [nitpick] After installing gcc@14, consider exporting its bin directory (e.g.,
export PATH="$(brew --prefix gcc@14)/bin:$PATH") so thatg++-14is reliably found on all macOS runners.
if ! brew list gcc@14 &>/dev/null; then
drbergman
left a comment
There was a problem hiding this comment.
This gets my approval. It's just changing the download packages for a windows install to run the test suite. If anyone with windows experience objects, please feel free to raise.
|
i just checked. brew nowadays ships with gcc version 16. the msys2 chaneges are still up to date. |
lately i was writing new physicell installation manuals for the power users.
thereby, i cleaned out the msys2 package list.
additionally, i noticed that brew nowadays ships with gcc version 14.
this is an update to the workflow files from what i learned on the way.