fix(viewer): open a window the way the device is already turned - #81
Merged
Merged
Conversation
The display report's rotation follows the app on screen, not the device, so the orientation comes from devicectl. A foldable's first answer after a turn repeats the one before it, so the question is asked twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: A window now reads how the device is turned when it opens, and is placed and shown in that shape, so a device left sideways opens sideways with its picture upright. The orientation comes from
devicectl device orientation get, because the display report's rotation follows the app on screen rather than the device. A foldable's first answer after a turn repeats the previous one, so the question is asked twice.Follow-ups: None.
Closes #73