feat(viewer): offer the camera control on every iPhone that has one - #80
Merged
Merged
Conversation
No device type or chrome bundle records the button, so the models that carry it are listed from Apple's hardware. The older input route accepts the same Snapshot usage the foldable uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: The older input route now sends the camera control as the same Snapshot usage the foldable uses, and the Device menu gains a Camera Control item. The item shows only while the device in front has the button, and a press only reaches open devices that have one. No device type or chrome bundle records the button, so the models are listed from Apple's hardware.
Follow-ups: The plain iPhone 18 needs adding once Xcode ships its device type.
Closes #72