fix(viewer): keep the standing foldable inside the window - #79
Merged
Merged
Conversation
Between about 45 and 10 degrees the device stands almost on edge and is taller than the open device the framing is held from, so it touched the top and bottom of the window, posed directly or mid move. The framing now checks the fill after centring and backs the camera off until the device covers no more than 0.98 of the picture; a clipped look is sized again from twice as far, and a move samples the standing band every five degrees so its path fits too. The presets keep their framing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Between about 45 and 10 degrees the foldable stands almost on edge and is taller than the open device the framing is held from, so it touched the top and bottom of the window, posed directly by a pinch or part way through a move. The framing now checks how much of the picture the device covers after centring and backs the camera off until it covers no more than 0.98, aiming at 0.95. A device cut off by the picture's edge measures as exactly full, so a clipped look is sized again from twice the distance. A move samples the stretch below 50 degrees every five degrees, one look each and cached per window size, and walks the camera's distance along with its position, so the standing poses mid move fit too. The presets keep the framing they had.
Closes #71.
Follow-ups: None.