feat(viewer): record a foldable from the panel the guest is using - #78
Merged
Merged
Conversation
simctl records one display per file, the inner panel whatever the fold, so a recording made shut was a movie of a screen nobody saw. A foldable now records itself from the frames its window already receives, into one movie the inner panel's size with the cover fitted on black, and a fold mid recording carries on. Ordinary devices keep simctl.
The inner panel is built a quarter turn round in its housing and the model undoes that when it draws; the recorder wrote the raw framebuffer, so an open device came out turned in the movie. Each panel's frames are turned by the same quarter turns, and the movie is the inner panel's size as shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: A foldable now records itself from the panel the guest is drawing on.
simctl io recordVideorecords one display per file, the inner panel whatever the fold, so a recording made shut was a movie of a screen nobody saw. The window already receives both panels' frames; a recorder in the app writes the followed panel's frames into one H.264 movie the inner panel's size, fitting the cover on black so it keeps its shape, and the panel switch that already moves touches and screenshots moves the recording too. Ordinary devices keepsimctl, through the same toggle.Closes #70.
Follow-ups: None.