Add capture controls, favorite locations, and settings improvements - #77
Merged
Merged
Conversation
Owner
|
Thanks. PR looks good. Please resolve conflicts |
…to dev # Conflicts: # engine/Sources/OpenDeviceHubViewer/ViewerMenu.swift
stephen-zeng
commented
Sep 27, 2026
stephen-zeng
left a comment
stephen-zeng
left a comment
Contributor
Author
There was a problem hiding this comment.
thank you. The conflict has been solved
Mastersam07
approved these changes
Sep 27, 2026
The Edit menu kept its own copy of the setting, read once, so turning sync off in Settings left the tick on and Get and Send Pasteboard greyed. The menu now reads the setting each time, and Settings refreshes its switch when the defaults change.
Removes two unused helpers, replaces the double optional folder lookup with one that falls back to the shared folder, explains a rejected favorite the way Custom Location does, and covers the folder migration with tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ViewerSettingstests for new preferences and location favorites.