Repository navigation
romanUmpire: number the feedback markers on the score - #105
Open
pjcdawkins wants to merge 1 commit into
Open
pjcdawkins wants to merge 1 commit into
pjcdawkins wants to merge 1 commit into
Conversation
writeScoreWithAnalysis marked each type of feedback on a chord with its
own text ("* Pitch", "* Beat", "* Bass"). Several on one chord, or on
chords close together, are wider than the music, so they overlap or
stack up, and they don't say which part of the printed feedback they
refer to.
Number each harmonic range with feedback instead, mark it on the score
with a warning sign and that number, colour the chord red (readers that
ignore text colour still show note colour), and start each message from
printFeedback with the same number in [brackets]. The warning sign keeps
the markers recognisable without colour: for colour-blind readers and in
black-and-white printing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013kxEDeNPrUAMYTU8TaoDGJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writeScoreWithAnalysis marked each type of feedback on a chord with its own text ("* Pitch", "* Beat", "* Bass"). Several on one chord, or on chords close together, are wider than the music, so they overlap or stack up, and they don't say which part of the printed feedback they refer to.
Number each harmonic range with feedback instead, mark it on the score with a warning sign and that number, colour the chord red (readers that ignore text colour still show note colour), and start each message from printFeedback with the same number in [brackets]. The warning sign keeps the markers recognisable without colour: for colour-blind readers and in black-and-white printing.
Claude-Session: https://claude.ai/code/session_013kxEDeNPrUAMYTU8TaoDGJ