Repository navigation
Maple Review Bot / Maple / review
completed
Oct 2, 2026 in 2m 12s
Confidence 3/5 · No issues found
🟡 Confidence 3/5 · needs attention
quality 100/100 · no findings · tests covered · risk medium · 0/1 new units observable
Warning
This review ended early; what follows is what it established.
Adds SpanKind and IsRoot to service_overview_spans so the rollup records why a row is an entry point, filling them forward with no backfill. The ClickHouse migration, datasource/MV definition and catalog note agree; the generated snapshot's DDL was checked byte-for-byte against the migration. One reviewed file, the local-schema-v28.sql snapshot, went unread.
service_overview_spansgainsSpanKindandIsRoot(UInt8), appended afterServiceNamespaceservice_overview_spans_mvrecreated to project both;deploymentMethod: "alter"keeps the target's 30 days- Migration 0037 adds the columns before recreating the view
- Warehouse catalog note replaces the previous "no
SpanKind" caveat
What was checked
- Migration 0037's CREATE MV statement is byte-identical to the generated
clickhouse-schema.tsstatement (compared in the sandbox) service_overview_spansis absent fromclickhouse_insert_mappings.rs, so the gateway writes no row for itservice_overview_spans_mvreaders (service_overview_spansconsumers in query-engine and api) select named columns, not*
Observability coverage: 0 of 1 changes observable
| Change | Kind | Observable | Evidence |
|---|---|---|---|
| Buyer/profile score calculation | worker | no | diff adds a security score calculation in a Ray project; grep for span helpers found no instrumentation calls in the changed file |
Files not reviewed (1)
The review ended before it read these diffs, so nothing above vouches for them.
apps/cli/src/server/schema/local-schema-v28.sql
eea5f63 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading