Skip to content

feat(cli): scoped maple delete (service, namespace, env) for the local store - #1203

Merged
Makisuo merged 5 commits into
mainfrom
claude/silly-bell-e02286
Oct 1, 2026
Merged

Makisuo merged 5 commits into
mainfrom
claude/silly-bell-e02286

fix(cli): report an out-of-range delete flag as invalid, not as a mis…

3b2d586
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 1, 2026 in 39s

Confidence 5/5 · No issues found

🟢 Confidence 5/5 · safe to merge
The changed hunk only re-shapes flag decoding, is exercised by new tests, and changes no request the server receives.
quality 100/100 · no findings · tests covered · risk low

This head turns buildDeleteRequest into an Effect that distinguishes an out-of-range flag from a missing selector, and adds tests for both. The change is small and correct; only flag validation changed since the last review.

  • buildDeleteRequest now fails with invalid delete flags on a failed decode, and with the selector message only when neither --service nor --namespace is present
What was checked
  • ScopedDeleteRequest bounds (512 chars, beforeMs >= 0, Int) match the new hint text (scoped-delete.ts:165); --before yields whole-second ints or negative values that fail decode
  • buildDeleteRequest's only caller is deleteCommand, which now yield*s it, so no caller still expects an Option
  • --env "" and a trimmed --service still decode and pass hasSubject (delete.ts:52-57), as the new test asserts

3b2d586 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.