Repository navigation
Model command arguments as struct parameters - #4
Merged
Merged
Conversation
- Translate sub-parameter id keys to zigpy field names when sending - Store an argument-taking main command's arguments as an id-keyed default_value so it stays main-parameter eligible - Map enum valid_values (command fields and attributes) value -> label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commands with arguments are SDK
structparameters (value keyed by sub-parameter id); argument-less commands staynone(buttons).default_arguments) still workdefault_value(a one-value button), so it still passescan_be_main_parametervalid_valuesare value → label for command fields and attributes (they were inverted)default_valuesurvives storage, so FanControl's off/on cycle stays a toggle);start_pairing_windowacceptscredentialsTests first (
6741ac8). Local:poe check --cigreen, 35 passed (py3.12; 35 on py3.13 before rebase).