Parse table/Server/defaultCharacterInfo.xml

[AngeloTadeucci]

table/Server/defaultCharacterInfo.xml had no type here, so a consumer that needs the per-gender default appearance (Maple2's gender-change voucher) had to hand-roll an XmlDocument walk over the entry. This adds the type and the parser method.

• Xml/Table/Server/DefaultCharacterInfo.cs: DefaultCharacterInfoRoot → gender blocks, each with skin and items/item, each item optionally carrying controls/control (hair transform). value is [M2dEnum] Gender; position/rotation are [M2dVector3].
• ServerTableParser.ParseDefaultCharacterInfo() returns (Gender, DefaultCharacterInfo), matching the other Parse* methods.
• colorSN defaults to -1, not 0. The attribute is absent on slots that keep the palette's own swatch, and 0 is a real swatch index.
• PackageVersion 2.4.20 → 2.4.21.

Verification

Ran a throwaway harness against the real Server.m2d and diffed the parsed tree against the raw XML entry. Every field round-trips:

gender=Male skin=(palette 1, sn 3)
  item id=10200003 slot=HR palette=2 sn=8 controls=2
    control index=0 scale=0.022728128 pos=<0, 0, 0> rot=<0, 0, 0>
    control index=1 scale=1 pos=<0, 0, 0> rot=<0, 0, 0>
  item id=10300002 slot=FA palette=3 sn=9 controls=0
  item id=10500001 slot=ER palette=0 sn=-1 controls=0
  item id=10400000 slot=FD palette=0 sn=-1 controls=0
gender=Female skin=(palette 1, sn 2)
  item id=10200012 slot=HR palette=2 sn=8 controls=2
    control index=0 scale=0.9497216 pos=<38.34204, -15.128418, -25.4962> rot=<22.039236, -77.53772, 3.0630174>
    control index=1 scale=0.9497216 pos=<38.308838, -15.503052, 25.071304> rot=<157.24625, -77.53734, -3.0525467>
  item id=10300004 slot=FA palette=3 sn=9 controls=0
  item id=10500001 slot=ER palette=0 sn=-1 controls=0
  item id=10400000 slot=FD palette=0 sn=-1 controls=0

dotnet build clean (0 errors), dotnet format whitespace --verify-no-changes clean.

Not run: dotnet test Maple2.File.Tests. It cannot start on my machine - TestUtils' static constructor trips a Debug.Fail inside AssetIndex for this data folder, which fails every test in the project, including untouched ones like TestMaidRecipe. The new TestDefaultCharacterInfo is therefore unexecuted; it asserts the same structure the harness above confirmed.

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

Summary by CodeRabbit

• New Features

  • Added support for parsing default character information, including gender, skin palettes, equipped items, controls, and positioning data.
  • Updated the parser package to version 2.4.21.

• Tests

  • Added coverage validating default character data, appearance slots, item identifiers, palette overrides, and character transforms.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c462d680-b145-44a1-a812-6b9bb63131c9

📥 Commits

Reviewing files that changed from the base of the PR and between d12f8a2 and 2cefa54.

📒 Files selected for processing (4)

• Maple2.File.Parser/Maple2.File.Parser.csproj
• Maple2.File.Parser/ServerTableParser.cs
• Maple2.File.Parser/Xml/Table/Server/DefaultCharacterInfo.cs
• Maple2.File.Tests/ServerTableParserTest.cs

---

📝 Walkthrough

Walkthrough

Adds XML models and ServerTableParser support for defaultCharacterInfo.xml. The test suite validates parsed genders, skin palettes, equipment slots, item IDs, palette sentinels, and control transforms. The parser package version increases from 2.4.20 to 2.4.21.

Changes

Default character info parsing

Layer / File(s)	Summary
XML model and parser support Maple2.File.Parser/Xml/Table/Server/DefaultCharacterInfo.cs, Maple2.File.Parser/ServerTableParser.cs	Adds XML-mapped default character models and a ParseDefaultCharacterInfo() method that returns entries keyed by Gender.
Parser validation and package update Maple2.File.Tests/ServerTableParserTest.cs, Maple2.File.Parser/Maple2.File.Parser.csproj	Adds assertions for parsed character data and updates the package version to 2.4.21.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant ServerTableParser
  participant defaultCharacterInfo.xml
  participant XmlSerializer
  ServerTableParser->>defaultCharacterInfo.xml: Load table data
  ServerTableParser->>XmlSerializer: Deserialize DefaultCharacterInfoRoot
  XmlSerializer-->>ServerTableParser: Return gender entries

Loading

Possibly related PRs

• MS2Community/Maple2.File#38: Adds another XML table model and parser method to ServerTableParser.
• MS2Community/Maple2.File#44: Adds XML parsing support, tests, and a package-version update.
• MS2Community/Maple2.File#54: Adds another XML serializer and parser method to ServerTableParser.

Suggested reviewers: zintixx

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/default-character-info-parser

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}