chore: add pre-commit - #128
Open
jjfrench wants to merge 1 commit into
Open
Conversation
hrodmn
approved these changes
Sep 8, 2026
hrodmn
left a comment
hrodmn
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding this! I have a few small suggestions but nothing blocking.
Comment on lines
+56
to
+59
| [tool.ruff.lint] | ||
| select = [ | ||
| "FAST", # fastapi | ||
| ] |
Member
Author
There was a problem hiding this comment.
I'll add the others from the root pyproject.toml 👍🏼
| additional_dependencies: | ||
| - types-requests | ||
| - pydantic>=2.13.4 | ||
| - pydantic-settings>=2.15.0 |
Contributor
There was a problem hiding this comment.
This pre-commit hook is nice for keeping pre-commit versions in sync with the uv.lock file. I'm not sure how that will interact with the dependabot config for pre-commit updates though 🤔
Suggested change
| - pydantic-settings>=2.15.0 | |
| - pydantic-settings>=2.15.0 | |
| - repo: https://github.com/tsvikas/sync-with-uv | |
| rev: v0.5.0 | |
| hooks: | |
| - id: sync-with-uv |
Member
Author
There was a problem hiding this comment.
Yeah 😕 it's sort of hit or miss - when updating just the uv.lock file, this seems to fail. Nice for local development - reminder for resyncing before pushing, but not so great for automated dependency updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.