Skip to content

fix(oauth): brand the OAuth publisher link and show its domain - #657

Merged
pcfreak30 merged 1 commit into
developfrom
fix/oauth-publisher-brand-link
Sep 1, 2026
Merged

fix(oauth): brand the OAuth publisher link and show its domain#657
pcfreak30 merged 1 commit into
developfrom
fix/oauth-publisher-brand-link

Conversation

@pcfreak30

@pcfreak30 pcfreak30 commented Sep 1, 2026

Copy link
Copy Markdown
Member

Shows the OAuth authorize page publisher as its bare domain (e.g. publisher.example)
while keeping the link pointed at the client metadata document.

Styles the publisher link with the Pinner teal accent instead of the browser-default
link color, matching the rest of the on-brand OOB pages.


Summary

This pull request improves the OAuth authorization page by branding the publisher link and displaying the publisher's domain instead of the full metadata URL.

Changes

Publisher Link Display

  • Before: The authorize page displayed the full client metadata URL (e.g., https://publisher.example/oauth-client.json) as the publisher link text.
  • After: The link text now shows only the domain (e.g., publisher.example) extracted from the URL, while the href still points to the full metadata document.

Implementation

  • Added a clientURIHost() helper function that safely extracts the host portion from a validated client URI, returning an empty string for unparseable URLs.
  • Updated both AuthorizeGET and AuthorizePOST handlers to compute and pass the new ClientDomain field alongside the existing ClientURI.

Styling

  • Added a new brand-link CSS utility that styles the publisher link with the accent teal color to match Pinner's branding, including hover, focus-visible, and visited states—ensuring it doesn't appear as a default browser link.

Tests

  • Updated existing tests to verify the link text shows the domain instead of the full URL and that the brand-link class is applied.
  • Added unit tests for clientURIHost() covering various URL formats, ports, and invalid inputs.

Impact

This change enhances the OAuth authorization page by making the publisher identity more recognizable to resource owners (showing a clean domain rather than a long metadata URL) and aligns the link styling with the overall Pinner visual identity.

@kody-ai

kody-ai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug
Performance
Security
Business Logic

Access your configuration settings here.

@pcfreak30
pcfreak30 merged commit 9264294 into develop Sep 1, 2026
12 of 13 checks passed
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

Code Coverage Report

Total Coverage: 50.1%

Generated from commit: 75f608e
Repository: LumeWeb/pinner-cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant