Repository navigation
1.1.0: re-export tracing from stratify::logging - #8
Merged
Merged
Conversation
The EnvFilter re-export already existed so callers would not need tracing-subscriber just to name a parameter type; every `tracing::info!` callsite still needed a direct tracing dependency, which is the same problem one layer down. `tracing` is how code emits and this crate is how records leave the process; re-exporting the former from the latter lets a service depend on stratify alone, with both halves guaranteed to agree on a version. `use stratify::logging::tracing;` at the top of a module keeps existing callsites compiling unchanged: the macros are $crate-hygienic, so they work without tracing in the consumer's manifest. Depending on tracing directly remains the ecosystem convention and remains available — this is for consumers who want one logging dependency. Pinned by an end-to-end test emitting through the re-export into a file sink. Verified: 274 tests all-features, 0 failing; clippy -D warnings clean; docs clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The instrumentation API, re-exported whole, so a service can depend on stratify alone:
use stratify::logging::tracing;keeps every existing callsite compiling unchanged. Same spirit as the existing EnvFilter re-export. Pinned by an end-to-end test through a file sink. Already published as 1.1.0.