Repository navigation
fix: don't attempt to up factions for players on wikis without factions - #8273
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The missing-data guards address the intended behavior, with no blocking issues identified in the changed code or affected callers.
No open issues 🎉
What changed in this PR
Prevents player faction lookups on wikis without faction support and makes the shared faction module tolerate missing faction data.
Changes:
- Adds a faction-support check before fetching player faction data.
- Makes faction data optional and guards faction helpers when it is absent.
- Removes the shared empty faction-data fallback.
| File | Description |
|---|---|
lua/wikis/commons/Player/Ext.lua |
Skips player faction lookups on unsupported wikis. |
lua/wikis/commons/Faction/Data.lua |
Removes the shared placeholder faction data. |
lua/wikis/commons/Faction.lua |
Loads faction data optionally and guards helpers with a support check. |
Review effort: Balanced
hjpalpha
approved these changes
Oct 22, 2026
ElectricalBoy
approved these changes
Oct 23, 2026
ElectricalBoy
left a comment
ElectricalBoy
left a comment
Member
There was a problem hiding this comment.
just a nitpick on missing type annotation
otherwise lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
How did you test this change?