Skip to content

fix(deps): alias image-size to image-size-next@1.2.2 (CVE-2025-71329/71330) - #250

Open
lcf2212dev wants to merge 1 commit into
LinusU:masterfrom
lcf2212dev:fix/image-size-next-1.2.2
Open

lcf2212dev wants to merge 1 commit into
LinusU:masterfrom
lcf2212dev:fix/image-size-next-1.2.2

Conversation

@lcf2212dev

Copy link
Copy Markdown

Why this PR

appdmg generates macOS DMG installers. On default master the published tarball depends on image-size@^0.7.4 and calls const sizeOf = require('image-size') in lib/appdmg.js so Finder-window background/icon layout can read PNG width/height.

Published appdmg@0.6.6 still depends on image-size@^0.7.4 (dependencies). Upstream image-size is archived. That coordinate remains affected by:

There is no patched release on the original package name. npm audit fix cannot rename the coordinate. This PR is a one-line alias so installs stop fetching the vulnerable tarball.

Change

Alias the published 1.x runtime dependency:

- "image-size": "^0.7.4"
+ "image-size": "npm:image-size-next@1.2.2"

Call sites left untouched:

  • test/lib/visually-verify-image.js:8 const sizeOf = require('image-size')
  • lib/appdmg.js:9 const sizeOf = require('image-size')

image-size-next@1.2.2 is a MIT community fork with the same 1.x public API. Compare: lcf2212dev/image-size-next@v1.2.1...v1.2.2

This is the 1.x pin (CJS default-export require('image-size') / import sizeOf from 'image-size' (0.x/1.x). Do not use image-size-next@2.1.1 here (ESM+CJS 2.x named imageSize export).)

Note: image-size-next@1.2.2 declares engines.node >= 16. This package currently lists engines.node >=8.5. If you still need older Node, vendoring the size helper is the alternative; the original image-size line has no patched tarball on any Node version.

Hub: lcf2212dev/image-size-next#3

I maintain image-size-next and am not affiliated with the original image-size author, nor with this project. Happy to drop the alias if you prefer vendoring the size helper.

Test plan

  • install resolves image-sizeimage-size-next@1.2.2
  • existing require/import of image-size needs no source edits
  • image width/height behaviour on the call sites above is unchanged

CVE-2025-71329 / CVE-2025-71330. Not affiliated with the original image-size maintainer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant