fix(deps): alias image-size to image-size-next@1.2.2 (CVE-2025-71329/71330) - #250
Open
lcf2212dev wants to merge 1 commit into
Open
lcf2212dev wants to merge 1 commit into
lcf2212dev wants to merge 1 commit into
Conversation
CVE-2025-71329 / CVE-2025-71330. Not affiliated with the original image-size maintainer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR
appdmggenerates macOS DMG installers. On defaultmasterthe published tarball depends onimage-size@^0.7.4and callsconst sizeOf = require('image-size')inlib/appdmg.jsso Finder-window background/icon layout can read PNG width/height.Published
appdmg@0.6.6still depends onimage-size@^0.7.4(dependencies). Upstreamimage-sizeis archived. That coordinate remains affected by:There is no patched release on the original package name.
npm audit fixcannot rename the coordinate. This PR is a one-line alias so installs stop fetching the vulnerable tarball.Change
Alias the published 1.x runtime dependency:
Call sites left untouched:
test/lib/visually-verify-image.js:8const sizeOf = require('image-size')lib/appdmg.js:9const sizeOf = require('image-size')image-size-next@1.2.2is a MIT community fork with the same 1.x public API. Compare: lcf2212dev/image-size-next@v1.2.1...v1.2.2This is the 1.x pin (CJS default-export
require('image-size')/import sizeOf from 'image-size'(0.x/1.x). Do not useimage-size-next@2.1.1here (ESM+CJS 2.x namedimageSizeexport).)Note:
image-size-next@1.2.2declaresengines.node >= 16. This package currently listsengines.node>=8.5. If you still need older Node, vendoring the size helper is the alternative; the originalimage-sizeline has no patched tarball on any Node version.Hub: lcf2212dev/image-size-next#3
I maintain
image-size-nextand am not affiliated with the originalimage-sizeauthor, nor with this project. Happy to drop the alias if you prefer vendoring the size helper.Test plan
image-size→image-size-next@1.2.2require/importofimage-sizeneeds no source edits