Repository navigation
Fix linter option names and the warnings they expose - #74
Merged
Merged
Conversation
Six linter options in `lakefile.lean` used names that no Mathlib linter
registers, so Lean ignored them and those linters never ran. Rename them to
`linter.style.{longLine,cdot,dollarSyntax,refine,missingEnd}` and drop
`linter.setOption`, which is already covered by `linter.style.setOption`.
Merge after the warning fixes for #71 have landed.
Closes #71.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Wrap lines over 100 characters and fix the other style linter warnings (`refine'`, focusing dots, missing `end`) reported once the linter option names in `lakefile.lean` are corrected. Formatting only; no statement changes. Part of #71. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Wrap lines over 100 characters and fix the other style linter warnings (`refine'`, focusing dots, missing `end`) reported once the linter option names in `lakefile.lean` are corrected. Formatting only; no statement changes. Part of #71. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Part of #71. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Wrap lines over 100 characters and fix the other style linter warnings (`refine'`, focusing dots, missing `end`) reported once the linter option names in `lakefile.lean` are corrected. Formatting only; no statement changes. Part of #71. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rAlgebra Wrap lines over 100 characters and fix the other style linter warnings (`refine'`, focusing dots, missing `end`) reported once the linter option names in `lakefile.lean` are corrected. Formatting only; no statement changes. Part of #71. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Wrap lines over 100 characters and fix the other style linter warnings (`refine'`, focusing dots, missing `end`) reported once the linter option names in `lakefile.lean` are corrected. Formatting only; no statement changes. Part of #71. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Six linter options in
lakefile.leanused names that no Mathlib linter registers, so those linters never ran (#71). This PR renames them to the registeredlinter.style.*names and fixes the warnings that the corrected linters report on the existing code.Changes
lakefile.lean: renamelinter.{longLine,cdot,dollarSyntax,refine,missingEnd}tolinter.style.*, and droplinter.setOption(already covered bylinter.style.setOption).longLine(1390): wrap lines over 100 characters.refine(44):refine'→refinewith?_; in a few places the hole thatrefine'used to elaborate is now passed as a named argument (e.g.Integrable.mono' (g := ...)).cdot(28):.→·.missingEnd(3): add the missingendinMoments/Cumulant,Rademacher/MassartandRademacher/Dudley.McDiarmid.lean: apply theTry this: rwa [this]suggestion.The changes are formatting only: no statement, name or proof strategy changes. Apart from whitespace, the diff consists of the
refine/cdot/endfixes above, a few;-chained tactics split onto separate lines, and long--comments split over two lines.Verification
lake buildsucceeds with the corrected linter names and reports no warnings or info messages.Closes #71.
🤖 Generated with Claude Code