munet: fix --pcaps=all - #78
Merged
Merged
Conversation
Fix a bug where self.switches.keys() does not have the split() method, and as a result, throws an error when 'all' is passed instead of the specific networks/interfaces. Note that 'all' will include all networks, but does not start pcaps for specific interfaces. Interfaces must still be specified as NODE:INTF. Signed-off-by: Liam Brady <lbrady@labn.net>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
- Coverage 59.17% 58.88% -0.29%
==========================================
Files 19 19
Lines 5832 5833 +1
==========================================
- Hits 3451 3435 -16
- Misses 2381 2398 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
choppsv1
reviewed
Oct 8, 2025
| pcapopt = set(pcapopt.split(",")) if pcapopt else set() | ||
| if 'all' in pcapopt: | ||
| pcapopt.remove('all') | ||
| pcapopt.update(self.switches.keys()) |
Collaborator
There was a problem hiding this comment.
how about this instead:
if pcapopt == "all":
pcapopt = self.switches.keys()
else
pcapopt = [x.strip() for x in pcapopt.split(',')]
for pcap in pcapopt:
...
Collaborator
There was a problem hiding this comment.
btw, we should be able to have all the modified lines tested, so 100% not 40% (of patched lines) :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug where self.switches.keys() does not have the split() method, and as a result, throws an error when 'all' is passed instead of the specific networks or interfaces.
Note that 'all' will include all networks with this fix but does not start pcaps for specific interfaces. Interfaces must still be specified as NODE:INTF.