munet: fix desync after send/expect - #67
Merged
Merged
Conversation
liambrady
force-pushed
the
liambrady/newline_desync
branch
from
July 25, 2025 18:55
6974934 to
deb4593
Compare
liambrady
changed the title
liambrady
force-pushed
the
liambrady/newline_desync
branch
from
July 25, 2025 18:57
deb4593 to
af608b3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
- Coverage 60.12% 60.07% -0.05%
==========================================
Files 19 19
Lines 5831 5829 -2
==========================================
- Hits 3506 3502 -4
- Misses 2325 2327 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
choppsv1
force-pushed
the
liambrady/newline_desync
branch
from
September 29, 2025 19:36
af608b3 to
d67db98
Compare
spawn() within shell_spawn() already provides a newline when no shell/login prompt is found. Sending a second newline after the expected prompt is detected results in a desync in the console I/O. This is because the response received from sending the newline is not consumed. Thus, any future instance after the desync of cmd_nostatus() or cmd_status() after shell_spawn() finishes either throws a warning or fails. The instability due to the desync can break following features that rely on such functionality, such as the mounting of shared volumes into the QEMU VM. Signed-off-by: Liam Brady <lbrady@labn.net>
choppsv1
force-pushed
the
liambrady/newline_desync
branch
from
September 29, 2025 20:04
d67db98 to
d611d46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spawn() within shell_spawn() already provides a newline when no shell/login prompt is found. Sending a second newline after the expected prompt is detected results in a desync in the console I/O. This is because response received from sending the newline is not consumed.
Thus, any future instance after the desync of cmd_nostatus() or cmd_status() after shell_spawn() finishes either throws a warning or an error. The instability due to the desync can break following features that rely on such functionality, such as the mounting of shared volumes into the QEMU VM.
As a bonus, this also cleans up the output of the
_console-log.txtfiles created for QEMU nodes. The I/O sequence is a lot easier to follow when there is no desync present.