Repository navigation
fix: inline composite action steps so releases don't edit workflow files - #7
Merged
Merged
Conversation
release-please failed with "Error adding to tree": GITHUB_TOKEN cannot commit changes under .github/workflows, and .yml extra-files also get the YAML ($.version) updater rather than the generic one. Inlining the SHA-pinned steps removes the self-reference entirely, so there is no @main and nothing for release automation to bump in workflow files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6. The release-please run after #6 merged failed:
Root cause (my mistake in #6):
.ymlpaths inextra-fileswith its YAML updater ($.version), not the genericx-release-please-versionupdater.GITHUB_TOKENcommit changes under.github/workflows/, so any release automation that rewrites these files would need a PAT or App token withworkflowscope.Fix: inline the steps from
actions/terraform-setup,aws-oidc-auth, andazure-oidc-auth(each a SHA-pinned third-party action) into both reusable workflows. With no self-reference, there's no@main, no tag to bump, and no token problem. The composite actions stay published for direct use, and Dependabot keeps all the SHAs current.extra-filesgoes back toREADME.mdonly. Behavior is unchanged: same action versions, same inputs,tflint --initstill runs at the repo root.Validation: actionlint 1.7.12 clean. After merge, release-please should open the v0.3.0 release PR.
🤖 Generated with Claude Code