Skip to content

data-turbo-frame="_self" not compatible with $dataTable->isRequestFromTurboFrame() #245

Description

@RafaelKr

I just noticed that clicking pagination links always sends back a full html document.
Inspecting the headers shows turbo-frame: _self, so it can't determine the actual data-table frame.

This seems like an upstream bug in Turbo, but maybe we could work around this by using 'data-turbo-frame': 'kreyu_data_table_' ~ data_table.vars.name for all pagination links for now. What do you think?

Edit: It's indeed an upstream issue: hotwired/turbo#1349

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions