Repository navigation
Fix some issues with samplers - #154
Open
ameligrana wants to merge 2 commits into
Open
ameligrana wants to merge 2 commits into
ameligrana wants to merge 2 commits into
Conversation
When the merged reservoirs saw fewer than n elements in total, they are all still filling up. merge/merge! now concatenate their raw elements (with shifted cumulative weights for AlgWRSWRSKIP) instead of drawing n samples, which biased value() and made AlgWRSWRSKIP throw.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some notable issues needed to be fixed.
Thanks to @mharinat for noticing and reporting the biased get of WRAExp-J and the off-by-one error in the binomial CDF computation.
The rest of the fixes are mostly related to merging reservoirs, which indeed is a less battle tested part of the library.