Repository navigation
fix: publish the Platform document's fragment under its dotted project - #143
Merged
Merged
Conversation
The Platform document's project is a domain, jorisjonkers.dev, and both the pack and the push refused it as not a name. A name is now one or more DNS labels joined by dots, which an OCI repository name also holds; a path, an upper-case letter, an empty label and a label that begins or ends with a hyphen are still refused before anything is pushed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jorisjonkers.dev(deploy-kitspec/v1/40-composition.md#participants), and is a participant like any project, so the estate publishes it throughpublish-fragment.pack.shandpush.shboth refused the name. A name is now one or more DNS labels joined by dots; an OCI repository name holds that, so it publishes toghcr.io/jorisjonkers-dev/intent-jorisjonkers.dev.a..b,.notes,notes.), and a label that starts with a hyphen.Test plan
python3 -m unittest discover -s tests: a new push test forjorisjonkers.dev, and the refusal test widened to the dotted cases above.shellcheckclean.Part of JorisJonkers-dev/estate#2.