Repository navigation
Fix storage correctness across acknowledgements and recovery - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes?
Corruption retirement could commit another worker's outstanding reservation, failed commit writes could make retries silently succeed, and interrupted recovery could lose the evidence needed to replay later segments. Partial header writes could also resurrect an append that had returned an error.
Add 28 focused regression tests covering reopened storage, injected failures, concurrent waiters and flushes, and real short header writes. Update package comments and the guide to match the corrected behavior.
How was this checked?
All passed locally:
make check: formatting, vet, pinned lint, normal and fault-injection suites with the race detector, and runnable examples.GOARCH=386).BenchmarkAddTake,BenchmarkAddTakeCommit,BenchmarkRead, andBenchmarkBatchCommit: all retain 0 allocs/op.git diff --check.Compatibility
No public API, on-disk format, dependency, or minimum Go-version changes. Opening a queue now fails if required cursor/count repairs cannot be persisted, and those repairs are flushed even under NoSync. Explicit Sync and Close also flush directory metadata under NoSync. Failed header writes remain retryable only when the previous published image is intact or restored; otherwise they report a latched ErrIO.