Skip to content

ci: run actionlint in Lint (#1967) - #2011

Merged
JarryShaw merged 1 commit into
mainfrom
ci/1967-actionlint
Oct 21, 2026
Merged

JarryShaw merged 1 commit into
mainfrom
ci/1967-actionlint

Conversation

@JarryShaw

Copy link
Copy Markdown
Owner

What is the purpose of your pull request?

  • ci — workflows or build tooling

Description of your pull request and other information

Step 4 of #1967. Lint's lint job runs actionlint 1.7.12 first, since it needs no Python.

  • The step downloads the release archive and checks it with sha256sum -c against a pinned sha256. The version and checksum sit in the step's env:. Dependabot does not track this pin.
  • Like the other Lint steps it is advisory (continue-on-error), with a 5-minute timeout and contents: read. The run summary counts findings by rule and by shellcheck code.
  • The one non-shellcheck finding is a false positive: project-status.yml's concurrency.queue, which GitHub documents but actionlint does not know yet (Actionlint does not know about queue: key for concurrency rhysd/actionlint#657). It gets a single -ignore matching only that message.
  • shellcheck reports 20 findings on run: blocks, all style or info. None is a real bug; the decision on what to do with them is asked on ci: divide and simplify the workflows into scripts, shared heads and smaller files #1967.

Tests and docs:

  • tests/project/test_actionlint_in_lint_1967.py pins the step. It fails against main (5 failed).
  • workflows.rst gains a Workflow Lint section.

Part of #1967.

- Lint's `lint` job gains an advisory `actionlint` step, first in the job:
  it downloads actionlint 1.7.12, verifies the archive against a pinned
  sha256 before unpacking, and runs it with the image's shellcheck. The run
  summary counts findings by actionlint rule and by shellcheck code.
- `concurrency.queue` in project-status.yml is a documented GitHub key no
  actionlint release knows yet (rhysd/actionlint#657), so one message-anchored
  `-ignore` hides that false positive and nothing else.
- tests/project/test_actionlint_in_lint_1967.py pins the step, its version
  floor, checksum and verify-before-unpack order, and the `-ignore` list.
- workflows.rst gains a Workflow Lint section.
@JarryShaw JarryShaw added ci Pull requests that change CI or workflow configuration (ci: subject prefix) review: running A cross-review is in flight against the current head - no verdict yet labels Oct 21, 2026
@JarryShaw JarryShaw moved this to In review in PyPCAPKit Oct 21, 2026
@JarryShaw

Copy link
Copy Markdown
Owner Author

GOOD TO GO at 7f8406e7b. A Sonnet review checked:

The shellcheck findings stay advisory pending the choice on #1967.

@JarryShaw JarryShaw added review: good-to-go Cross-review at the current head says ready; CI state is separate and removed review: running A cross-review is in flight against the current head - no verdict yet labels Oct 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Coverage: 91.55% (unit tier, Python 3.15, 7f8406e7b, Unit Tests run success)

Package Statements Missed Branches Partial Cover
pcapkit (top level) 104 4 20 2 95.16%
pcapkit/const 19597 881 2618 867 92.11%
pcapkit/corekit 2542 71 810 37 96.54%
pcapkit/dumpkit 276 3 100 3 98.40%
pcapkit/foundation 2930 23 1022 25 98.79%
pcapkit/interface 138 4 52 3 96.32%
pcapkit/protocols 17501 222 4612 187 98.13%
pcapkit/toolkit 872 36 298 10 95.21%
pcapkit/utilities 523 2 158 4 99.12%
pcapkit/vendor 4431 1995 1018 167 51.73%

Per-file detail: the coverage-html artifact of this run.

@JarryShaw
JarryShaw merged commit 861985e into main Oct 21, 2026
60 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in PyPCAPKit Oct 21, 2026
@JarryShaw
JarryShaw deleted the ci/1967-actionlint branch October 21, 2026 04:10
@JarryShaw JarryShaw removed the review: good-to-go Cross-review at the current head says ready; CI state is separate label Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Pull requests that change CI or workflow configuration (ci: subject prefix)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant