Repository navigation
ci: run actionlint in Lint (#1967) - #2011
Merged
Merged
Conversation
- Lint's `lint` job gains an advisory `actionlint` step, first in the job: it downloads actionlint 1.7.12, verifies the archive against a pinned sha256 before unpacking, and runs it with the image's shellcheck. The run summary counts findings by actionlint rule and by shellcheck code. - `concurrency.queue` in project-status.yml is a documented GitHub key no actionlint release knows yet (rhysd/actionlint#657), so one message-anchored `-ignore` hides that false positive and nothing else. - tests/project/test_actionlint_in_lint_1967.py pins the step, its version floor, checksum and verify-before-unpack order, and the `-ignore` list. - workflows.rst gains a Workflow Lint section.
Owner
Author
|
GOOD TO GO at
The shellcheck findings stay advisory pending the choice on #1967. |
Contributor
|
Coverage: 91.55% (unit tier, Python 3.15,
Per-file detail: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
ci— workflows or build toolingDescription of your pull request and other information
Step 4 of #1967. Lint's
lintjob runs actionlint 1.7.12 first, since it needs no Python.sha256sum -cagainst a pinned sha256. The version and checksum sit in the step'senv:. Dependabot does not track this pin.continue-on-error), with a 5-minute timeout andcontents: read. The run summary counts findings by rule and by shellcheck code.project-status.yml'sconcurrency.queue, which GitHub documents but actionlint does not know yet (Actionlint does not know aboutqueue:key for concurrency rhysd/actionlint#657). It gets a single-ignorematching only that message.run:blocks, all style or info. None is a real bug; the decision on what to do with them is asked on ci: divide and simplify the workflows into scripts, shared heads and smaller files #1967.Tests and docs:
tests/project/test_actionlint_in_lint_1967.pypins the step. It fails againstmain(5 failed).workflows.rstgains a Workflow Lint section.Part of #1967.