GraalPy: collect_until's late-finaliser test outruns its 5 s grace #2016
Copy link
Copy link
Closed
Labels
bugIssues reporting a defect (set by the bug report template; a default, not an assessment)Issues reporting a defect (set by the bug report template; a default, not an assessment)testPull requests that add or correct tests (test: subject prefix)Pull requests that add or correct tests (test: subject prefix)
Milestone
Description
Describe the bug
On GraalPy, FinaliserBackstopWithoutDel.test_collect_until_waits_out_a_finaliser_that_runs_late in tests/foundation/test_extraction_ownership.py fails: collect_until(late, grace=5.0) returns False. The predicate needs three collections, and under the loaded sharded run, GraalPy does not fit three gc.collect calls into the hard-coded 5 s.
Reproduction
The graalpy-25.4 experimental leg on main f96a6b156 (job):
> self.assertTrue(collect_until(late, grace=5.0))
E AssertionError: False is not true
Expected behavior
The test should check how collect_until behaves without depending on how fast gc.collect runs on the engine.
System information
- OS Version: ubuntu-latest (GitHub Actions)
- Python Implementation: GraalPy 25.4
- commit:
f96a6b156
Additional context
This came out of the #1963 re-measure. collect_until came from #2010.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugIssues reporting a defect (set by the bug report template; a default, not an assessment)Issues reporting a defect (set by the bug report template; a default, not an assessment)testPull requests that add or correct tests (test: subject prefix)Pull requests that add or correct tests (test: subject prefix)
Projects
- StatusShow more project fieldsDone
Activity
test: drive collect_until's late-finaliser test off a fake clock (#2016)
test: drive collect_until's late-finaliser test off a fake clock (#2016…