Skip to content

Name Command kinds in Console Lanes and Stages headings - #948

Merged
JacobStephens2 merged 4 commits into
mainfrom
issue-936
Oct 21, 2026
Merged

JacobStephens2 merged 4 commits into
mainfrom
issue-936

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 21, 2026 •

Copy link
Copy Markdown
Owner

Summary

-acme/widgets#7
-acme/widgets#7
+Pickup run · acme/widgets#7
+Run · acme/widgets#7

Name each Command's recorded kind in Lanes and Stages headings, including History entries and mobile cell labels. Issue-free Commands keep <kind> on <repository>. One formatter serves both record and History observations.

Closes #936

Evidence

  • Before: cargo test --test console time_pages_name_the_command_kind_without_repeating_it_for_commands_without_issues -- --exact failed on the missing Pickup/Run kind. Extending it with a History entry failed on the missing History kind.
    After: cargo test --test console time_pages_ passes both tests, including the retained regression.
  • cargo test --test console: 41 passed.
  • cargo test: full Rust suite passed.
  • cd console && npm test: 36 passed, covering distinct live Pickup/Run headings, Spec/Ticket Run headings, issue-free headings, exact peek selection, CLI parity, cell labels and no sideways scroll at 390 px.
  • After the formatter cleanup, cd console && node --test tests/time.test.cjs: 3 passed.
  • cargo fmt --check and cargo clippy --all-targets -- -D warnings: passed.

Test seams

  • The Console's rendered Lanes and Stages pages over fixture Command records and History entries, paired with thirdshift status --all --json.
  • The browser pages at 390 px, including headings, hidden cell labels and peek links.

Review coverage

Independent Standards and Spec reviews compared main...HEAD, including the formatter follow-up. Both read every changed file: src/logs/status/time.rs, tests/console.rs, and console/tests/time.test.cjs.

Standards: one optional duplication finding addressed by the shared formatter; no remaining findings. Spec: no findings. Unread changed files: none on either axis. Generated-output exclusions: none.

Unaddressed findings

Standards

None.

Spec

None.

Security review outcome

  • Security review incomplete: session failed, ended early or omitted a valid final line; see Session log

Merge Danger

Door: two-way

The display change can be reverted without a data migration.

Blast Radius: Console

Built with codex · gpt-6.1-sol · high

JacobStephens2 and others added 4 commits October 21, 2026 13:39
Import both Issue and StageName in the time views: this branch's shared
heading formatter takes an Issue, and main's dispatch-stage Usual range
check uses StageName.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@JacobStephens2
JacobStephens2 merged commit 5f645b9 into main Oct 21, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-936 branch October 21, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Stages and Lanes pages head a Pickup run and the Run it dispatched identically

1 participant