Skip to content

Show no Usual range for dispatch stages - #944

Merged
JacobStephens2 merged 1 commit into
mainfrom
issue-924
Oct 21, 2026
Merged

JacobStephens2 merged 1 commit into
mainfrom
issue-924

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 21, 2026 •

Copy link
Copy Markdown
Owner

Summary

Dispatch rows on the Console's Stages page now show that they have no Usual range. Ordinary ranges and stage cells keep their existing behavior.

 Stages row heading
-dispatched Run      Usual range: Not enough samples
-dispatched Spec run Usual range: Not enough samples
+dispatched Run      Usual range: —
+dispatched Spec run Usual range: —

Closes #924

Evidence

  • Before: cargo test --test console stages_distinguishes_dispatch_from_insufficient_usual_range_samples -- --exact failed because the live dispatch row said Usual range: Not enough samples.
    After: The same test passes for both dispatch names and checks ordinary insufficient samples, live Running · 1 min cells, and other Commands' Not reached · — cells.
  • cargo test --test console: 41 passed, including the existing non-dispatch Usual range coverage.
  • cargo test: full Rust suite passed (the unit suite has two ignored tests).
  • cargo fmt --check, git diff --check, and cargo clippy --all-targets -- -D warnings passed.

Test seams

  • Console HTTP Stages page backed by Command record fixtures: dispatch row headings, ordinary Usual range headings, and live dispatch cell text.

Review coverage

Independent Standards and Spec reviews used git diff main...HEAD (main: eb7a8474f865c4fc67f8208196d711198379dda3). Both axes read all changed files: src/logs/status/time.rs and tests/console.rs. No changed files were left unread; no generated output was excluded. Reports, including each axis's final files-read list, are saved in .thirdshift-review-U6Hleh/standards.md and .thirdshift-review-U6Hleh/spec.md in the implementation worktree.

Unaddressed findings

  • Standards: None; no findings.
  • Spec: None; no findings.

Security review outcome

  • Security review incomplete: session failed, ended early or omitted a valid final line; see Session log

Merge Danger

Door: two-way

A revert restores the previous row text; no stored records change.

Blast Radius: Console

Only dispatch-stage Usual range text changes on the Stages page.

Built with codex · gpt-6.1-sol · high

@JacobStephens2
JacobStephens2 merged commit 6a1897e into main Oct 21, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-924 branch October 21, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Stages page says a dispatch stage has "Not enough samples", though it never gets a Usual range

1 participant