Repository navigation
Keep responsive layouts when the app's stylesheet loads last - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The host adds its stylesheet again after the module sheets, so its plain utilities (
.w-full,.grid-cols-1,.hidden) win over this module's breakpoint variants whenever the host doesn't happen to emit the same variant. Today that left the report totals in 2 columns on desktop, the unbilled-time filters full width and the timer chip's padding unchanged atmd; the other grids worked only because the host currently ships the same variants.Each responsive property is now split into ranges that never overlap (
max-sm:grid-cols-1 sm:max-lg:grid-cols-2 lg:grid-cols-4,max-lg:flex-col), so only one class applies at any width. The billing filters get a wrapper that owns the width, sinceBaseInputGroupcarries its ownw-full. Checked at 1440, 800 and 390 px.