Repository navigation
Show bundled dependencies and record slots in Hello World - #5
Merged
Merged
Conversation
Version 2.0.0 targets module API 1.4. It bundles chillerlan/php-qrcode, which InvoiceShelf does not ship, and uses it in a module route that draws a QR code for the dashboard; bundle.lock is committed and bundle/ is generated (and kept out of Pint). The page, invoices and customers show what the new record slots look like: a panel, a Say hello action in list menus and on the invoice page, and a New-menu entry. The README now explains local development with a bundle and dependency management end to end. CI builds the bundle from bundle.lock against the host's 3.x lock, and releases build it against 3.0.0-alpha.12 through the SDK 3.5 workflow. SDK 3.5.0 is not tagged yet, so composer install fails until it is.
BasePage already spaces the header from the content and BaseCard already pads its body, so the page's own margin and padding doubled both. The layout now also uses only utilities the host's stylesheet has, since the module ships no CSS of its own.
SDK 3.5.0 is tagged, so the temporary preview step goes. composer.lock is committed (resolved for PHP 8.4, the module's minimum) because the bundle build checks that the versions the tests use match the ones that ship.
gdarko
marked this pull request as ready for review
October 24, 2026 00:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello World 2.0.0, the reference for bundled dependencies and record slots (module API 1.4):
chillerlan/php-qrcode, which InvoiceShelf does not ship; a module route draws a QR code with it on the dashboard.bundle.lockis committed,bundle/is generated and kept out of Pint.Waits for SDK 3.5.0 (
composer installcannot resolve^3.5until it is tagged) and for the first host release with module API 1.4 (host-version: 3.0.0-alpha.12in the release workflow). Stacked on the modernization PR.