Add build option for ILP64 - #184
Open
ndgrigorian wants to merge 2 commits into
Open
Conversation
ndgrigorian
marked this pull request as ready for review
April 13, 2026 16:18
ndgrigorian
requested review from
antonwolfy,
jharlow-intel and
xaleryb
as code owners
April 13, 2026 16:18
ndgrigorian
force-pushed
the
use-meson-build
branch
from
May 10, 2026 01:12
ef09add to
ac6e9fc
Compare
ndgrigorian
force-pushed
the
add-ilp64-build-option
branch
2 times, most recently
from
May 10, 2026 01:41
7e1f82a to
b06c721
Compare
ndgrigorian
force-pushed
the
use-meson-build
branch
from
May 15, 2026 20:08
ac6e9fc to
b39b64b
Compare
fixes compiler warning about unused function
ndgrigorian
force-pushed
the
add-ilp64-build-option
branch
from
August 6, 2026 14:12
b06c721 to
cacc4ab
Compare
antonwolfy
reviewed
Aug 6, 2026
There was a problem hiding this comment.
Pull request overview
Adds a Meson build-time option to compile mkl-service against MKL’s ILP64 interface, and uses that option to conditionally compile the ILP64 vs LP64 init path in the Linux preload/init extension to avoid unused-function compiler warnings.
Changes:
- Introduces a new Meson boolean option
ilp64inmeson.options. - Wires
-DMKL_ILP64into the Mesonc_argswhen the option is enabled. - Gates
_set_mkl_ilp64()/_set_mkl_lp64()compilation and selection inmkl/_mklinitmodule.c.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
mkl/_mklinitmodule.c |
Conditionally compiles and selects ILP64 vs LP64 init helper to avoid unused code paths and warnings. |
meson.options |
Adds a new ilp64 boolean build option. |
meson.build |
Attempts to add -DMKL_ILP64 to compiler args when the option is enabled. |
Collaborator
Author
|
CI failures are unrelated to PR content and are likely some kind of server issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
meson.optionsfile and adds a build option for ILP64.With this option added, the definition of functions for initializing MKL with the ILP64 interface are gated by ifdefs, silencing a compiler warning