Add MKLMemory class to expose MKL allocated memory via Python buffer protocol - #182
Open
ndgrigorian wants to merge 12 commits into
Open
Add MKLMemory class to expose MKL allocated memory via Python buffer protocol#182ndgrigorian wants to merge 12 commits into
MKLMemory class to expose MKL allocated memory via Python buffer protocol#182ndgrigorian wants to merge 12 commits into
Conversation
ndgrigorian
force-pushed
the
feature/add-mkl-memory
branch
5 times, most recently
from
April 12, 2026 07:19
aed1ff6 to
a99e626
Compare
ndgrigorian
marked this pull request as ready for review
April 12, 2026 09:03
ndgrigorian
requested review from
antonwolfy,
jharlow-intel and
xaleryb
as code owners
April 12, 2026 09:03
ndgrigorian
force-pushed
the
use-meson-build
branch
from
May 10, 2026 01:12
ef09add to
ac6e9fc
Compare
ndgrigorian
force-pushed
the
feature/add-mkl-memory
branch
3 times, most recently
from
May 10, 2026 02:02
b2cc6fc to
00fea26
Compare
ndgrigorian
force-pushed
the
use-meson-build
branch
from
May 15, 2026 20:08
ac6e9fc to
b39b64b
Compare
exposes Python buffer protocol
as atomics are a c11+ feature, specific flags are needed to enable on window
ndgrigorian
force-pushed
the
feature/add-mkl-memory
branch
from
August 6, 2026 15:58
00fea26 to
c764a81
Compare
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a new MKLMemory Cython extension type backed by MKL’s allocator, exposes it from the top-level mkl package, and introduces tests/build changes to support C11 atomics and nogil MKL calls.
Changes:
- Introduce
mkl._mkl_memorywithMKLMemory(allocation, buffer protocol, pickling, realloc). - Add pytest coverage for allocation, buffer protocol, and pickling behavior.
- Update MKL C-API declarations/build to support
nogilcalls and C11 atomics (plus MSVC flag).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| mkl/tests/test_mkl_memory.py | Adds tests for MKLMemory creation, buffer protocol, and pickling behavior. |
| mkl/_py_mkl_service.pyx | Releases the GIL around MKL buffer-free calls. |
| mkl/_mkl_service.pxd | Marks MKL externs as nogil and adds malloc/calloc/realloc/free declarations. |
| mkl/_mkl_memory.pyx | Adds the new MKLMemory Cython extension implementing allocation + buffer protocol + pickling. |
| mkl/init.py | Exposes MKLMemory at the package top level. |
| meson.build | Enables C11, adds MSVC atomics flag, and builds the new _mkl_memory extension. |
also address issues with undeclared variables and rename MKLMemory class members
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes the introduction of
_mkl_memory.pyx, which implements anMKLMemoryclass that exposes memory allocated viamkl_mallocandmkl_callocto Python via the buffer protocolThe class uses an atomic counter incremented as
__getbuffer__and__releasebuffer__are called to track the views on the buffer to permit use ofmkl_reallocin the object (viareallocmethod). This concept was adapted from the PEP which revised the buffer protocol which proposed this kind of approach to tracking views on a bufferCloses #18