Switch to conda-forge ocl-icd loader packages - #2905
Merged
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev3=py314h509198e_46 ran successfully. |
ndgrigorian
reviewed
May 7, 2026
Co-authored-by: ndgrigorian <46709016+ndgrigorian@users.noreply.github.com>
Collaborator
|
coverage: 78.411% (-0.003%) from 78.414% — switch-to-conda-forge-ocl-icd into master |
antonwolfy
changed the title
ocl-icd from conda-forgeocl-icd loader packages
antonwolfy
marked this pull request as ready for review
August 3, 2026 09:06
antonwolfy
marked this pull request as draft
August 3, 2026 09:45
antonwolfy
marked this pull request as ready for review
August 3, 2026 10:07
…and runtime 2026.1.1 or newer
…s to 2026.1.1 and add MIN_BUILD_CMPL_MKL_VERSION to override that
ndgrigorian
reviewed
Aug 3, 2026
ndgrigorian
approved these changes
Aug 3, 2026
ndgrigorian
left a comment
ndgrigorian
left a comment
Collaborator
There was a problem hiding this comment.
LGTM aside from above point about updating comments
Contributor
Author
|
The PR will be merged, once LKG on Linux for DPC++ compiler includes fixes from 2026.1.1 release. |
github-actions Bot
added a commit
that referenced
this pull request
Aug 5, 2026
Switches the OpenCL ICD loader run dependency from `intel-gpu-ocl-icd-system` to the conda-forge loaders when building against a DPC++ compiler and runtime of `2026.1.1` or newer: - **Linux:** `ocl-icd-system` - **Windows:** `khronos-opencl-icd-loader` The conda-forge loaders require compiler/runtime `2026.1.1`+, so the choice is gated on the compiler version the package is built against. When building against an older compiler, the recipe keeps the legacy `intel-gpu-ocl-icd-system` package. The `-system` variant on Linux is intentional: it symlinks the system-installed OpenCL ICD loader into the environment rather than bundling its own, so the Intel GPU driver's registered ICD is discovered correctly. Using the bundling `ocl-icd` package instead shadows the system loader and breaks device enumeration. ## Decoupled compiler and oneMKL floors The single `required_compiler_and_mkl_version` constant is split into two independent minimums, because the DPC++ compiler and oneMKL do not release in lockstep: the compiler has a `2026.1.1` build on the public channels, but `mkl-devel-dpcpp` only goes up to `2026.1.0`. Keeping them coupled made a `2026.1.1` floor unsolvable. ac5346b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the OpenCL ICD loader run dependency from
intel-gpu-ocl-icd-systemto the conda-forge loaders when building against a DPC++ compiler and runtime of2026.1.1or newer:ocl-icd-systemkhronos-opencl-icd-loaderThe conda-forge loaders require compiler/runtime
2026.1.1+, so the choice is gated on the compiler version the package is built against. When building against an older compiler, the recipe keeps the legacyintel-gpu-ocl-icd-systempackage.The
-systemvariant on Linux is intentional: it symlinks the system-installed OpenCL ICD loader into the environment rather than bundling its own, so the Intel GPU driver's registered ICD is discovered correctly. Using the bundlingocl-icdpackage instead shadows the system loader and breaks device enumeration.Decoupled compiler and oneMKL floors
The single
required_compiler_and_mkl_versionconstant is split into two independent minimums, because the DPC++ compiler and oneMKL do not release in lockstep: the compiler has a2026.1.1build on the public channels, butmkl-devel-dpcpponly goes up to2026.1.0. Keeping them coupled made a2026.1.1floor unsolvable.