Skip to content

Update OpenCL loader search in CMake - #2356

Merged
ndgrigorian merged 3 commits into
masterfrom
update-opencl-loader-search
Aug 7, 2026
Merged

Update OpenCL loader search in CMake#2356
ndgrigorian merged 3 commits into
masterfrom
update-opencl-loader-search

Conversation

@ndgrigorian

Copy link
Copy Markdown
Collaborator

This PR updates the OpenCL loader search used when building dpctl, as pi_opencl is no longer used, and the open-source compiler is currently not packaging libur_adapter_opencl.so.

By adding OpenCL to the search, a libOpenCL.so installed by ocl-icd can be linked to in place of the UR adapter if it is not found.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian
ndgrigorian force-pushed the update-opencl-loader-search branch from 768a6bb to 38b4795 Compare August 6, 2026 20:15
@ndgrigorian
ndgrigorian marked this pull request as ready for review August 6, 2026 20:15
@ndgrigorian
ndgrigorian force-pushed the update-opencl-loader-search branch from 38b4795 to 58f2e3d Compare August 7, 2026 01:44
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls

coveralls commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 74.054%. remained the same — update-opencl-loader-search into master

@ndgrigorian
ndgrigorian force-pushed the update-opencl-loader-search branch from 2c0adc0 to 6291348 Compare August 7, 2026 06:50

@antonwolfy antonwolfy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are passing, LGTM

@ndgrigorian
ndgrigorian merged commit 97f634e into master Aug 7, 2026
86 of 91 checks passed
@ndgrigorian
ndgrigorian deleted the update-opencl-loader-search branch August 7, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants