Skip to content

Remove sub_group_independent_forward_progress device info query #2353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ndgrigorian wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove sub_group_independent_forward_progress device info query #2353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions dpctl/_backend.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,9 +234,6 @@ cdef extern from "syclinterface/dpctl_sycl_device_interface.h":
cdef bool DPCTLDevice_IsAccelerator(const DPCTLSyclDeviceRef DRef)
cdef bool DPCTLDevice_IsCPU(const DPCTLSyclDeviceRef DRef)
cdef bool DPCTLDevice_IsGPU(const DPCTLSyclDeviceRef DRef)
cdef bool DPCTLDevice_GetSubGroupIndependentForwardProgress(
const DPCTLSyclDeviceRef DRef
)
cdef uint32_t DPCTLDevice_GetPreferredVectorWidthChar(
const DPCTLSyclDeviceRef DRef
)
Expand Down
15 changes: 0 additions & 15 deletions dpctl/_sycl_device.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ from ._backend cimport ( # noqa: E211
DPCTLDevice_GetPreferredVectorWidthShort,
DPCTLDevice_GetProfilingTimerResolution,
DPCTLDevice_GetSingleFPConfig,
DPCTLDevice_GetSubGroupIndependentForwardProgress,
DPCTLDevice_GetSubGroupSizes,
DPCTLDevice_GetVendor,
DPCTLDevice_GetVendorId,
Expand Down Expand Up @@ -1246,20 +1245,6 @@ cdef class SyclDevice(_SyclDevice):
)
return max_num_sub_groups

@property
def sub_group_independent_forward_progress(self):
""" Returns ``True`` if the device supports independent forward progress
of sub-groups with respect to other sub-groups in the same work-group.

Returns:
bool:
Indicates if the device supports independent forward progress
of sub-groups.
"""
return DPCTLDevice_GetSubGroupIndependentForwardProgress(
self._device_ref
)

@property
def sub_group_sizes(self):
""" Returns tuple of supported sub-group sizes for this device.
Expand Down
8 changes: 0 additions & 8 deletions dpctl/tests/_device_attributes_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,13 +322,6 @@ def check_image_3d_max_depth(device):
pytest.fail("image_3d_max_depth call failed")


def check_sub_group_independent_forward_progress(device):
try:
device.sub_group_independent_forward_progress
except Exception:
pytest.fail("sub_group_independent_forward_progress call failed")


def check_preferred_vector_width_char(device):
try:
device.preferred_vector_width_char
Expand Down Expand Up @@ -812,7 +805,6 @@ def check_partition_affinity_domains(device):
check_is_accelerator,
check_is_cpu,
check_is_gpu,
check_sub_group_independent_forward_progress,
check_preferred_vector_width_char,
check_preferred_vector_width_short,
check_preferred_vector_width_int,
Expand Down
12 changes: 0 additions & 12 deletions libsyclinterface/include/syclinterface/dpctl_sycl_device_interface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,18 +458,6 @@ DPCTL_API
__dpctl_give DPCTLDeviceVectorRef DPCTLDevice_CreateSubDevicesByAffinity(
__dpctl_keep const DPCTLSyclDeviceRef DRef,
DPCTLPartitionAffinityDomainType PartAffDomTy);
/*!
* @brief Wrapper over
* device.get_info<info::device::sub_group_independent_forward_progress>.
*
* @param DRef Opaque pointer to a ``sycl::device``
* @return Returns true if the device supports independent forward progress of
* sub-groups with respect to other sub-groups in the same work-group.
* @ingroup DeviceInterface
*/
DPCTL_API
bool DPCTLDevice_GetSubGroupIndependentForwardProgress(
__dpctl_keep const DPCTLSyclDeviceRef DRef);

/*!
* @brief Wrapper over
Expand Down
16 changes: 0 additions & 16 deletions libsyclinterface/source/dpctl_sycl_device_interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,22 +408,6 @@ declmethod(GetImage3dMaxHeight, image3d_max_height, size_t);
declmethod(GetImage3dMaxDepth, image3d_max_depth, size_t);
#undef declmethod

bool DPCTLDevice_GetSubGroupIndependentForwardProgress(
__dpctl_keep const DPCTLSyclDeviceRef DRef)
{
bool SubGroupProgress = false;
auto D = unwrap<device>(DRef);
if (D) {
try {
SubGroupProgress = D->get_info<
info::device::sub_group_independent_forward_progress>();
} catch (std::exception const &e) {
error_handler(e, __FILE__, __func__, __LINE__);
}
}
return SubGroupProgress;
}

namespace
{

Expand Down
21 changes: 0 additions & 21 deletions libsyclinterface/tests/test_sycl_device_interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,18 +233,6 @@ TEST_P(TestDPCTLSyclDeviceInterface, ChkIsGPU)
EXPECT_NO_FATAL_FAILURE(DPCTLDevice_IsGPU(DRef));
}

TEST_P(TestDPCTLSyclDeviceInterface, ChkGetSubGroupIndependentForwardProgress)
{
bool sub_group_progress = 0;
EXPECT_NO_FATAL_FAILURE(
sub_group_progress =
DPCTLDevice_GetSubGroupIndependentForwardProgress(DRef));
auto D = reinterpret_cast<device *>(DRef);
auto get_sub_group_progress =
D->get_info<info::device::sub_group_independent_forward_progress>();
EXPECT_TRUE(get_sub_group_progress == sub_group_progress);
}

TEST_P(TestDPCTLSyclDeviceInterface, ChkGetPreferredVectorWidthChar)
{
uint32_t vector_width_char = 0;
Expand Down Expand Up @@ -1003,15 +991,6 @@ TEST_F(TestDPCTLSyclDeviceNullArgs, ChkGetMaxImageDims)
ASSERT_TRUE(res == 0);
}

TEST_F(TestDPCTLSyclDeviceNullArgs, ChkGetSubGroupIndependentForwardProgress)
{
bool indep_pr = true;
EXPECT_NO_FATAL_FAILURE(
indep_pr =
DPCTLDevice_GetSubGroupIndependentForwardProgress(Null_DRef));
ASSERT_FALSE(indep_pr);
}

TEST_F(TestDPCTLSyclDeviceNullArgs, ChkGetPreferredVectorWidth)
{
uint32_t w = -1;
Expand Down
Loading