Repository navigation
knowledge(vllm-omni): 1 change(s) from refine - #422
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7cb52b9359
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ## VLLM-OMNI-PR9390-DUPLEXEVAL-JUDGE-SCORES — Omni-DuplexEval 判分门槛：finish_reason=stop、按任务分数校验、原始回复轨迹与重试归档，judge 失败先走既有回退 | ||
|
|
||
| - 触发：改动 `vllm_omni/benchmarks/duplex/` 判分链路——`omni_duplex_eval_metrics.py`（`parse_judge_json`）、`omni_duplex_eval_judge.py`（`DuplexJudge`、`JudgeResponseError`）、`omni_duplex_eval_eval.py`（`evaluate_sample`、`summarize_scores` 及 content 判分失败后的回退）——或其测试 `tests/benchmarks/duplex/test_omni_duplex_eval_judge.py`、`tests/benchmarks/duplex/test_omni_duplex_eval_serving.py`、`tests/e2e/features/fullduplex/test_omni_duplex_eval_cli.py`，或 `docs/cli/bench/serve.md` 中 judge 回复要求与重试工件小节。`vllm bench serve` 接线与运行目录语义见 VLLM-OMNI-PR8645-DUPLEXEVAL-BENCH，夜间守卫调用方式见 VLLM-OMNI-PR8871-DUPLEXEVAL-CI；本规则只覆盖判分校验本身，不改变那两条规则的门槛。 |
There was a problem hiding this comment.
This rule exclusively governs vllm_omni/benchmarks/duplex/, but its body is added at the repository root and linked only from the root index. The existing benchmark/_index.md already routes Omni-DuplexEval work within the benchmark owner, so readers following that entry do not encounter the new scoring constraints. This violates the nearest-owner requirement in root AGENTS.md. Put the rule in benchmark/rules.md (or an owner-scoped topic page reachable from it), update the benchmark index, and keep any repository-root entry as routing only.
AGENTS.md reference: AGENTS.md:L12-L14
Useful? React with 👍 / 👎.
|
Knowledge quality gate · checked 2026-10-26 at Result: not passed. This PR will not be merged until the problems below are fixed; push a fix and it is checked again at the next daily pass. Problems:
|
Generated automatically by the Copilot knowledge service (changeset
vllm-omni-refine-7b3701904897).repos/vllm-omni/rules-duplexeval-judge.mdGenerator:
zcode:GLM-5.3· judge:codex:gpt-6-sol:medium.The publisher merges it only if its local gate passes on the exact merge result.