Repository navigation
knowledge(vllm-omni): 1 change(s) from refine - #402
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d93b1523fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ## VLLM-OMNI-PR8258-REALTIME-CONFORMANCE — /v1/realtime WebSocket 一致性回归：created 先于首个 updated 与空 commit 报错 | ||
|
|
||
| - 触发：改动 Qwen3-Omni `/v1/realtime` WebSocket 协议行为——`session.created` / `session.updated` 事件的产生、顺序或 `session` 对象字段，或 `input_audio_buffer.commit` 对空音频缓冲的处理——或改动 `tests/entrypoints/openai_api/test_qwen3_omni_realtime_websocket.py` 中 `TestQwen3OmniRealtimeWebSocket` 的协议一致性测试（`test_session_lifecycle_events`、`test_empty_commit_returns_error`）及其 `_conformance_recv_until` / `_conformance_events_of_type` / `_conformance_open_session` 辅助函数。 |
There was a problem hiding this comment.
The Direct route table sends WebSocket/OpenAI changes to components/serving/rules.md, while this repository-root page is linked only from _index.md, which Direct reviews do not revisit after resolving an exact owner. Consequently, future reviews of the behavior described here will not load this rule. Move the conclusion into the serving owner—likely components/serving/rules-realtime-openai.md—and expose it through the serving quick map/index instead.
AGENTS.md reference: AGENTS.md:L12-L14
Useful? React with 👍 / 👎.
Generated automatically by the Copilot knowledge service (changeset
vllm-omni-refine-f9a381e3bfe6).repos/vllm-omni/rules-realtime-conformance.mdGenerator:
zcode:GLM-5.3· judge:codex:gpt-6-sol:medium.The publisher merges it only if its local gate passes on the exact merge result.