Repository navigation
knowledge(vllm-omni): 1 change(s) from refine - #401
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42db19b29c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - 验收：`test_thinker_prefix_cache_defaults` 在最终 `stage0.yaml_engine_args["enable_prefix_caching"]` 上断言实际参数化的行：两个 CUDA turn profile 为 `True`；这两个 profile 在 npu/rocm/xpu/musa 下为 `False`；CUDA 下所列 MRv2 / duplex / base profile 行为 `False`（非 CUDA 平台仅对这两个 turn profile 有覆盖，新增其它 profile×platform 组合须自行补参数行）。测试须 pin `platforms.current_omni_platform.device_name` 并走 `_apply_platform_overrides` + `merge_pipeline_deploy`；e2e 断言 Thinker 开、Talker/Code2Wav 保持关，并附 batch-invariant（46/46）、Daily-Omni（0.7157 vs 0.7157）、Seed-TTS WER（0.0207 vs 0.0215）等行为等价证据；文档（`docs/serving/video_stream_api.md`）与新默认值同步。 | ||
| ^[PR #9203] | ||
|
|
||
| <!-- kb:rule status=active since=v0.30.0 --> |
There was a problem hiding this comment.
At the reviewed commit, PR #9203 is still open against main, but this marker advertises its behavior as active since v0.30.0, a release that predates the PR. Reviews consuming the knowledge tree can therefore require defaults and tests that are absent from the released and audited source snapshot. Keep this as a candidate until the prerequisite PRs and #9203 merge, then activate it with the correct release/source pin.
AGENTS.md reference: knowledge/AGENTS.md:L16-L16
Useful? React with 👍 / 👎.
|
|
||
| # Thinker prefix cache deploy 默认值 | ||
|
|
||
| ## VLLM-OMNI-PR9203-THINKER-PREFIX-CACHE — Thinker prefix cache 默认开启仅限已验证的 CUDA turn profile |
There was a problem hiding this comment.
This PR-derived rule is added as a standalone page, but the prescribed owner route stops at components/configuration/rules.md, so reviewers following that route will never load these constraints merely because _index.md links them. PR/review intake is explicitly restricted to executable rules in the nearest owner's rules.md; merge the reusable invariant into that routed file rather than creating this parallel rule page.
AGENTS.md reference: AGENTS.md:L12-L17
Useful? React with 👍 / 👎.
Generated automatically by the Copilot knowledge service (changeset
vllm-omni-refine-4ed843575a53).repos/vllm-omni/components/configuration/rules-thinker-prefix-cache.mdGenerator:
zcode:GLM-5.3· judge:codex:gpt-6-sol:medium.The publisher merges it only if its local gate passes on the exact merge result.