Fix OpenMP compiler warnings in FFT and archive deserialization - #592
Open
aaadelmann wants to merge 5 commits into
Open
Fix OpenMP compiler warnings in FFT and archive deserialization#592aaadelmann wants to merge 5 commits into
aaadelmann wants to merge 5 commits into
Conversation
Member
Author
|
cscs-ci run cscs-ci-gh200, cscs-ci-mi300, cscs-ci-openmp |
Use std::cmp_greater when checking the iteration range against the hash view extent to avoid mixed-sign comparison warnings.
Initialize the charge entrance flag and bunching factor before use to eliminate Release-build maybe-uninitialized warnings.
aaadelmann
requested review from
rammann and
srikrrish
and removed request for
srikrrish
August 15, 2026 06:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Fix OpenMP & HIP compiler warnings in FFT and archive deserialization
PR description
Summary
This PR fixes compiler warnings reported by the OpenMP & HIP builds without disabling warnings or adding compiler-specific switches.
g2andm2variables inPrunedCC.has[[maybe_unused]].This addresses the warnings from:
Testing
All green at https://my.cdash.org/index.php?project=IPPL
Release OpenMP build with GCC 15.2:
At four ranks,
NedelecSpacefails because its test domain supports at most three partitions. All communication, particle-update, FFT, and NUFFT tests passed at four ranks.The reported
PrunedCC.handArchive.hppwarnings no longer appear.ToDo
A separate PR for the G200 these are architectural