Fix L0-L2 CDFs Logical_source_description

[leowerneck]

Change Summary

Related to #3438 and imap_l3_processing:#199.

The changes in this PR were are to make L0-L2 comply with @jtniehof comment in imap_l3_processing:#202, which suggested using the instrument names in the logical source description.

Overview

Fix IMAP datasets names to include the pattern:

Logical_source_description: "IMAP Mission <Instrument Name> ..."

File Changes

The following changes were made:

• Added missing "IMAP Mission" (i.e., <instrument> -> IMAP Mission <instrument>):
  • imap_processing/cdf/config/imap_hi_global_cdf_attrs.yaml
  • imap_processing/cdf/config/imap_lo_global_cdf_attrs.yaml
  • imap_processing/cdf/config/imap_ultra_global_cdf_attrs.yaml
• Added missing "Mission" (i.e., IMAP <instrument> -> IMAP Mission <instrument>):
  • imap_processing/cdf/config/imap_swapi_global_cdf_attrs.yaml
  • imap_processing/cdf/config/imap_swe_global_cdf_attrs.yaml

Note

The following files do not satisfy the pattern, but I am unsure how to fix them: * `imap_processing/cdf/config/imap_ialirt_global_cdf_attrs.yaml` - Currently: `IMAP Active Link for Real-Time (I-ALiRT) Level-1 Data` - Fix: `IMAP Mission Active ...` or `IMAP Mission IMAP Active ...`? * `imap_processing/cdf/config/imap_spacecraft_global_cdf_attrs.yaml` - Currently: `IMAP Quaternion Level-...` - Fix: `IMAP Mission Quaternion ...` or `IMAP Mission IMAP Quaternion ...`?

After a brief Slack discussion, the following changes were made:

• IMAP Active Link for Real-Time (I-ALiRT) -> IMAP Mission IMAP Active Link for Real-Time (I-ALiRT)
• IMAP Quaternion Level-1* Data From the Spacecraft -> IMAP Mission Spacecraft Level-1* Quaternion Data

Let me know if there are objections.

[vineetbansal]

Looks good - to answer your questions above (and this might affect this PR anyway) - unless you know of other reasons, my recommendation would be to stick to capitalized (as appropriate, see iAlirt) versions of VALID_INSTRUMENTS from https://github.com/IMAP-Science-Operations-Center/imap-data-access/blob/08b0d3eac152bf4954db30a9ae0124559e658935/imap_data_access/__init__.py#L89.

So, for example, Hi instead of IMAP-Hi; SpaceCraft and IAlirt for your questions above.

[leowerneck]

So, for example, Hi instead of IMAP-Hi; SpaceCraft and IAlirt for your questions above.

The changes in this PR were meant to make L0-L3 comply with Jon's comment in imap_l3_processing:#202 to use the instrument names. I realize this would've been useful information to add to the PR description, so I'll update it.

[vineetbansal]

@leowerneck - ah I see. In that case, LGTM!

[tmplummer]

🚀